Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target dialog made responsive, fixed filtering with targetless option #20

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Target dialog made responsive, fixed filtering with targetless option #20

merged 2 commits into from
Jun 23, 2023

Conversation

Razz4780
Copy link
Contributor

Solves #19

  1. Scroll list inside the dialog is now resized with the dialog itself
  2. The dialog is initially shown with width and height matching the list contents
  3. Fixed an issue with list filtering - targetless mode option was sorted along with pods, now it's always at the bottom

aviramha
aviramha approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@aviramha aviramha added this pull request to the merge queue Jun 23, 2023
Merged via the queue into metalbear-co:main with commit a232f5e Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviramha aviramha aviramha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Razz4780 @aviramha