SIP sidestepping for tomcat, using force accessing of fields #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4lz
force-pushed
the
tommy-override-default
branch
from
5fbf84d to
7ac36da
Compare
The layer is now loaded successfuly, but then fails to connect to the intproxy.
t4lz
force-pushed
the
tommy-override-default
branch
from
7ac36da to
2958eab
Compare
t4lz
force-pushed
the
tommy-override-default
branch
from
2958eab to
70eb26f
Compare
t4lz
commented
Nov 15, 2023
...ucts/tomcat/src/main/kotlin/com/metalbear/mirrord/products/tomcat/TomcatExecutionListener.kt
Show resolved
Hide resolved
aviramha
approved these changes
Nov 15, 2023
|
Great job! |
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very hacky way to solve that problem, but the only solution I got to work so far.
We force change a field accessibility and then set it.
So far the SIP-sidestepping works, and a browser window pops up. By default the url is localhost:8080, which works. We could think about trying to find out the remote external IP and port and change it to that, but I assume it's not required for now - the user can set the remote url in the launch configuration.
Stopping still requires pressing the button twice, but there is no error message.