Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for having a macro in mirrord config path #243

Closed
aviramha opened this issue Mar 8, 2024 · 1 comment
Closed

Add support for having a macro in mirrord config path #243

aviramha opened this issue Mar 8, 2024 · 1 comment

Comments

@aviramha
Copy link
Member

aviramha commented Mar 8, 2024

When users pass config file to use via "MIRRORD_CONFIG_FILE" env, they can't use relative paths (since they don't know what it is relative to).
Add support for expanding $ProjectPath$ in that value before passing it to actual execution.
aviramha added a commit to aviramha/mirrord-intellij that referenced this issue Mar 9, 2024
@aviramha
Added support for using $ProjectPath$ macro in MIRRORD_CONFIG_FILE en…
92565e2 
…v closing metalbear-co#243
@aviramha aviramha mentioned this issue Mar 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 11, 2024
@aviramha @Razz4780
Added support for using $ProjectPath$ macro in MIRRORD_CONFIG_FILE (#…
b1506a7 
…244)

* Added support for using $ProjectPath$ macro in MIRRORD_CONFIG_FILE env closing #243

* lint

* cr

* Update modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecManager.kt

Co-authored-by: Michał Smolarek <[email protected]>

---------

Co-authored-by: Michał Smolarek <[email protected]>
@aviramha
Copy link
Member Author

Closed via #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aviramha