Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Conditions in CAPM3 #127

Closed
Arvinderpal opened this issue Jul 28, 2020 · 12 comments
Closed

Add support for Conditions in CAPM3 #127

Arvinderpal opened this issue Jul 28, 2020 · 12 comments
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@Arvinderpal
Copy link
Contributor

CAPI has recently adopted the use of Conditions to provide better visibility into the current state of the workload cluster. We should add similar functionality to CAPM3.

References:
CAEP: kubernetes-sigs/cluster-api#3017

Related:
Docker Cluster Conditions
AWS Cluster Conditions
@dhellmann dhellmann added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Aug 5, 2020
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2020
@metal3-io-bot
Copy link
Contributor

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

@metal3-io-bot
Copy link
Contributor

@metal3-io-bot: Closing this issue.

In response to this:

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Arvinderpal
Copy link
Contributor Author

/reopen

@metal3-io-bot
Copy link
Contributor

@Arvinderpal: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot reopened this Dec 3, 2020
@metal3-io-bot
Copy link
Contributor

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

@metal3-io-bot
Copy link
Contributor

@metal3-io-bot: Closing this issue.

In response to this:

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Arvinderpal Arvinderpal mentioned this issue Oct 20, 2021
Closed
@Arvinderpal
Copy link
Contributor Author

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2021
@fmuyassarov
Copy link
Member

/reopen

@metal3-io-bot
Copy link
Contributor

@fmuyassarov: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot reopened this Oct 22, 2021
@Arvinderpal Arvinderpal mentioned this issue Oct 29, 2021
Merged
@fmuyassarov
Copy link
Member

It was fixed in metal3-io/cluster-api-provider-metal3#357
/close

@metal3-io-bot
Copy link
Contributor

@fmuyassarov: Closing this issue.

In response to this:

It was fixed in metal3-io/cluster-api-provider-metal3#357
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest kashifest moved this to Feature request in Metal3 - Roadmap Jun 26, 2024
@Rozzii Rozzii moved this from Feature request to Generic Improvement in Metal3 - Roadmap Jun 26, 2024
@Rozzii Rozzii moved this to Done / Closed in Metal3 - Roadmap Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
Metal3 - Roadmap
Status: Done / Closed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dhellmann @Arvinderpal @fmuyassarov @metal3-io-bot