Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Pin IPA version #1504

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Pin IPA version #1504

wants to merge 1 commit into from

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Feb 17, 2025 •
edited
Loading

Pin IPA version
Related PR in BMO: metal3-io/baremetal-operator#2264

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 17, 2025
@peppi-lotta peppi-lotta mentioned this pull request Feb 17, 2025
Open
lentzi90
lentzi90 reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
Sunnatillo
Sunnatillo reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thank you.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
@Sunnatillo
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-9 metal3-dev-env-integration-test-ubuntu-main

elfosardo
elfosardo suggested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@elfosardo elfosardo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not really point to stable branches but to the corresponding bugfix ones based on the ironic releases

elfosardo
elfosardo reviewed Feb 18, 2025
View reviewed changes
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/pin-ipa-version branch from 705f92f to f46a8e9 Compare February 18, 2025 11:09
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
@metal3-io-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

elfosardo
elfosardo reviewed Feb 18, 2025
View reviewed changes
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/pin-ipa-version branch from f46a8e9 to 4c67b18 Compare February 18, 2025 13:58
@peppi-lotta
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-9 metal3-dev-env-integration-test-ubuntu-main

@Rozzii
Copy link
Member

Rozzii commented Feb 20, 2025

/test metal3-centos-e2e-integration-test-release-1-9

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Feb 20, 2025 •
edited
Loading

@peppi-lotta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-centos-e2e-integration-test-release-1-9 4c67b18 link true /test metal3-centos-e2e-integration-test-release-1-9

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Rozzii
Rozzii requested changes Feb 20, 2025
View reviewed changes
lib/common.sh Outdated
@@ -288,6 +288,7 @@ if [[ "${CAPM3RELEASEBRANCH}" = "release-1.7" ]]; then
export BARE_METAL_OPERATOR_TAG="v0.6.2"
export KEEPALIVED_TAG="v0.6.2"
export IRONIC_TAG="v24.1.2"
export IPA_BRANCH="stable/2024.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take into consideration that the IPA is not build from source in dev-env rather pulled from here https://tarballs.opendev.org/openstack/ironic-python-agent/. Please make sure that you specify the "branch" in a way that it is understandable for the IPA downloader.

I would recommend not specifying branches rather full file names that will be used here https://github.com/metal3-io/ironic-ipa-downloader/blob/main/get-resource.sh#L29 and this way the whole IPA pinning would be more explicit and easier to understand and track.

@peppi-lotta
Copy link
Member Author

I made this small PR in ipa-downloader that I think should merge before I make further changes in this PR.

@peppi-lotta
Pin IPA version
6fca084 
Signed-off-by: peppi-lotta <[email protected]>
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/pin-ipa-version branch from 4c67b18 to 6fca084 Compare February 25, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@elfosardo elfosardo elfosardo requested changes

@Sunnatillo Sunnatillo Sunnatillo left review comments

@Rozzii Rozzii Rozzii requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@peppi-lotta @metal3-io-bot @Sunnatillo @Rozzii @lentzi90 @elfosardo