Firmware install param #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelrebel
force-pushed
the
firmware-install-param
branch
from
52733e0 to
afdc7f4
Compare
DoctorVin
previously approved these changes
Oct 20, 2023
go.mod
Outdated
| @@ -10,7 +10,7 @@ require ( | |||
| github.com/google/uuid v1.3.1 | |||
| github.com/metal-toolbox/conditionorc v0.0.4 | |||
| github.com/metal-toolbox/hollow-bomservice v0.1.1 | |||
| github.com/metal-toolbox/rivets v0.0.0-20230927091114-c7072205b479 | |||
| github.com/metal-toolbox/rivets v0.0.0-20231020103738-10fc2993b885 | |||
There was a problem hiding this comment.
we should not lose sight of cutting real releases off rivets.
…meter This would cause flasher to fail the task if the host is powered on.
joelrebel
force-pushed
the
firmware-install-param
branch
from
afdc7f4 to
4c38300
Compare
|
rebase on main |
DoctorVin
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install firmware-setCLI flag--require-host-powered-on