Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple integration tests for conditionals and for #187 #188

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Add simple integration tests for conditionals and for #187 #188

merged 3 commits into from
Mar 3, 2022

Conversation

TobiasNx
Copy link
Collaborator

@TobiasNx TobiasNx commented Mar 3, 2022

@TobiasNx TobiasNx requested a review from blackwinter March 3, 2022 09:28
blackwinter
blackwinter requested changes Mar 3, 2022
View reviewed changes
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all vs. any doesn't make much sense if there's only one value to test.

...etafacture/metafix/integration/conditional/fromJson/toJson/IfAny_containSimple/expected.json Outdated Show resolved Hide resolved
...etafacture/metafix/integration/conditional/fromJson/toJson/ifAll_containSimple/expected.json Outdated Show resolved Hide resolved
...acture/metafix/integration/conditional/fromJson/toJson/unlessAll_containSimple/expected.json Outdated Show resolved Hide resolved
...acture/metafix/integration/conditional/fromJson/toJson/unlessAny_containSimple/expected.json Outdated Show resolved Hide resolved
@blackwinter blackwinter assigned TobiasNx and unassigned blackwinter Mar 3, 2022
@blackwinter blackwinter self-requested a review March 3, 2022 11:37
@TobiasNx TobiasNx assigned blackwinter and unassigned TobiasNx Mar 3, 2022
blackwinter
blackwinter requested changes Mar 3, 2022
View reviewed changes
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IfAny_containSimple should be ifAny_containSimple.

...metafix/integration/conditional/fromJson/toJson/unlessAny_containArrayOfStrings/disabled.txt Outdated Show resolved Hide resolved
...metafacture/metafix/integration/conditional/fromJson/toJson/ifAll_containSimple/disabled.txt Outdated Show resolved Hide resolved
...metafacture/metafix/integration/conditional/fromJson/toJson/IfAny_containSimple/disabled.txt Outdated Show resolved Hide resolved
...facture/metafix/integration/conditional/fromJson/toJson/ifAll_containArrayOfStrings/test.fix Outdated Show resolved Hide resolved
...facture/metafix/integration/conditional/fromJson/toJson/ifAny_containArrayOfStrings/test.fix Outdated Show resolved Hide resolved
@blackwinter blackwinter assigned TobiasNx and unassigned blackwinter Mar 3, 2022
@TobiasNx TobiasNx requested a review from blackwinter March 3, 2022 12:51
@TobiasNx TobiasNx merged commit 02652c9 into master Mar 3, 2022
@TobiasNx TobiasNx deleted the 160-integrationTestsForConditionals branch March 3, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackwinter blackwinter blackwinter approved these changes

Assignees

@TobiasNx TobiasNx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobiasNx @blackwinter