Close LineRecorder receiver's stream when closing LineRecorder #433
Assignees
Labels
Comments
dr0i
added a commit
that referenced
this issue
Dec 27, 2021
Under some circumstances (probably if the JVM is not stopped after processing) the streams of receivers connected to LineRecorder are not closed, resulting in empty or missing output data. - complement test
dr0i
added a commit
that referenced
this issue
Dec 30, 2021
Under some circumstances (e.g. if the JVM is not stopped after processing) the streams of receivers connected to LineRecorder are not closed, resulting in empty or missing output data. By switch from "implements ObjectPipe" to "extends DefaultObjectPipe" the "DefaultSender" is used which implements the Sender interface. This ensures the proper closing of streams. - complement test
dr0i
added a commit
that referenced
this issue
Dec 30, 2021
Under some circumstances (e.g. if the JVM is not stopped after processing) the streams of receivers connected to LineRecorder are not closed, resulting in empty or missing output data. By switching from "implements ObjectPipe" to "extends DefaultObjectPipe" in LineRecorde the "DefaultSender" is used which implements the Sender interface. This ensures the proper closing of streams. - complement test
dr0i
added a commit
that referenced
this issue
Jan 11, 2022
Some "@OverRide" methods used the "public" modifier, which is not necessary. Looking at the base classes of these classes a "protected" modifier was used, so "protected" seems to be intentionally.
dr0i
added a commit
that referenced
this issue
Jan 11, 2022
Some "@OverRide" methods used the "public" modifier, which is not necessary. Looking at the base classes of these classes a "protected" modifier was used, so "protected" seems to be intentionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This came up in metafacture/metafacture-playground#25 (comment):
Processing a flux pipeline results in empty data when doing this e.g. with the metafacture-playground, while it works fine when processing it using standalone
metafacture-core.The cause is probably: if the JVM is stopped after processing the streams of the receivers are closed automatically, thus the data is output correctly, while an unstopped JVM (like with
metafacture-playground) doesn't close all streams properly (in some cases). Here it is theLineRecorderwhich doesn't close its receiver.The text was updated successfully, but these errors were encountered: