Use "protected" on all "on...()" methods (#435)

Some "@OverRide" methods used the "public" modifier, which is not necessary. Looking at the base classes of these classes a "protected" modifier was used, so "protected" seems to be intentionally.
metafacture · Jan 11, 2022 · 53b322f · 53b322f
1 parent 72617a0
commit 53b322f
Show file tree

Hide file tree

Showing 11 changed files with 15 additions and 15 deletions.
diff --git a/...cture-javaintegration/src/main/java/org/metafacture/javaintegration/pojo/PojoEncoder.java b/...cture-javaintegration/src/main/java/org/metafacture/javaintegration/pojo/PojoEncoder.java
@@ -107,12 +107,12 @@ private static Object createObjectFromString(final String value,
     }
 
     @Override
-    public void onCloseStream() {
+    protected void onCloseStream() {
         typeEncoderStack.clear();
     }
 
     @Override
-    public void onResetStream() {
+    protected void onResetStream() {
         typeEncoderStack.clear();
     }
 

diff --git a/metafacture-mangling/src/main/java/org/metafacture/mangling/RecordIdChanger.java b/metafacture-mangling/src/main/java/org/metafacture/mangling/RecordIdChanger.java
@@ -217,18 +217,18 @@ public void literal(final String name, final String value) {
     }
 
     @Override
-    public void onSetReceiver() {
+    protected void onSetReceiver() {
         streamBuffer.setReceiver(getReceiver());
     }
 
     @Override
-    public void onResetStream() {
+    protected void onResetStream() {
         streamBuffer.clear();
         entityPathTracker.resetStream();
     }
 
     @Override
-    public void onCloseStream() {
+    protected void onCloseStream() {
         streamBuffer.clear();
         entityPathTracker.closeStream();
     }

diff --git a/metafacture-mangling/src/main/java/org/metafacture/mangling/RecordPathFilter.java b/metafacture-mangling/src/main/java/org/metafacture/mangling/RecordPathFilter.java
@@ -166,13 +166,13 @@ public void literal(final String name, final String value) {
     }
 
     @Override
-    public void onResetStream() {
+    protected void onResetStream() {
         entityPathTracker.resetStream();
         resetRecord();
     }
 
     @Override
-    public void onCloseStream() {
+    protected void onCloseStream() {
         entityPathTracker.closeStream();
     }
 

diff --git a/metafacture-statistics/src/main/java/org/metafacture/statistics/Counter.java b/metafacture-statistics/src/main/java/org/metafacture/statistics/Counter.java
@@ -112,7 +112,7 @@ public void endEntity() {
     }
 
     @Override
-    public void onResetStream() {
+    protected void onResetStream() {
         numRecords = 0;
         numEntities = 0;
         numLiterals = 0;

diff --git a/metafacture-strings/src/main/java/org/metafacture/strings/LineRecorder.java b/metafacture-strings/src/main/java/org/metafacture/strings/LineRecorder.java
@@ -78,7 +78,7 @@ protected void onCloseStream() {
     }
 
     @Override
-    public void onResetStream() {
+    protected void onResetStream() {
         record = new StringBuilder(SB_CAPACITY);
     }
 

diff --git a/metafacture-xml/src/main/java/org/metafacture/xml/XmlElementSplitter.java b/metafacture-xml/src/main/java/org/metafacture/xml/XmlElementSplitter.java
@@ -192,7 +192,7 @@ public String getXmlDeclaration() {
     }
 
     @Override
-    public void onResetStream() {
+    protected void onResetStream() {
         reset();
     }
 

diff --git a/metamorph/src/main/java/org/metafacture/metamorph/Entity.java b/metamorph/src/main/java/org/metafacture/metamorph/Entity.java
@@ -124,7 +124,7 @@ protected void clear() {
     }
 
     @Override
-    public void onNamedValueSourceAdded(final NamedValueSource namedValueSource) {
+    protected void onNamedValueSourceAdded(final NamedValueSource namedValueSource) {
         sourceList.add(namedValueSource);
         sourcesLeft.add(namedValueSource);
     }

diff --git a/metamorph/src/main/java/org/metafacture/metamorph/collectors/All.java b/metamorph/src/main/java/org/metafacture/metamorph/collectors/All.java
@@ -67,7 +67,7 @@ protected void emit() {
     }
 
     @Override
-    public void onNamedValueSourceAdded(final NamedValueSource namedValueSource) {
+    protected void onNamedValueSourceAdded(final NamedValueSource namedValueSource) {
         sources.add(namedValueSource);
         sourcesLeft.add(namedValueSource);
     }

diff --git a/metamorph/src/main/java/org/metafacture/metamorph/collectors/Choose.java b/metamorph/src/main/java/org/metafacture/metamorph/collectors/Choose.java
@@ -79,7 +79,7 @@ protected void receive(final String newName, final String newValue, final NamedV
     }
 
     @Override
-    public void onNamedValueSourceAdded(final NamedValueSource namedValueSource) {
+    protected void onNamedValueSourceAdded(final NamedValueSource namedValueSource) {
         priorities.put(namedValueSource, Integer.valueOf(nextPriority));
         nextPriority += 1;
     }

diff --git a/metamorph/src/main/java/org/metafacture/metamorph/collectors/Combine.java b/metamorph/src/main/java/org/metafacture/metamorph/collectors/Combine.java
@@ -61,7 +61,7 @@ protected void receive(final String name, final String value, final NamedValueSo
     }
 
     @Override
-    public void onNamedValueSourceAdded(final NamedValueSource namedValueSource) {
+    protected void onNamedValueSourceAdded(final NamedValueSource namedValueSource) {
         sources.add(namedValueSource);
         sourcesLeft.add(namedValueSource);
     }

diff --git a/metamorph/src/main/java/org/metafacture/metamorph/collectors/EqualsFilter.java b/metamorph/src/main/java/org/metafacture/metamorph/collectors/EqualsFilter.java
@@ -68,7 +68,7 @@ protected void receive(final String name, final String value, final NamedValueSo
     }
 
     @Override
-    public void onNamedValueSourceAdded(final NamedValueSource namedValueSource) {
+    protected void onNamedValueSourceAdded(final NamedValueSource namedValueSource) {
         sources.add(namedValueSource);
         sourcesLeft.add(namedValueSource);
     }