PICARD-3034: Fix win-build-fixes.ps1 not being called #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phw
force-pushed
the
PICARD-3034-fix-win-packaging-dlls
branch
from
acd0e12 to
872cd82
Compare
|
Tested the installer. The changes work as expected and all DLLs are in the root folder again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
This fixes packaging issues on Windows, where system wide Qt and libssl related libraries would be loaded over the bundled ones.
This was originally fixed in PICARD-2736. But the change in PICARD-3002 moved the cleanup code to a separate helper script
win-build-fixes.ps1, which was forgotten to be called.Solution
Call
win-build-fixes.ps1