LB-1103: Only show front cover art in ListenCards #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requested on the ticket, fro cases where the user has provided a release MBID, but there is no front image for it. In that case, fallback to another method to get a front cover
anshg1214
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @Aerozol, for cases where the user has provided a release MBID, but there is no front image for that release (for example a vinyl release with liner notes added but no front cover: https://musicbrainz.org/release/ce5deb72-4bc3-461f-b92e-1637709f70ef/cover-art).
In that case, fallback to another method to get a front cover (from the release group, finds a front image if there is one), in this case: https://musicbrainz.org/release/62d9695f-ac89-474c-b9c8-ee95828e2e58/cover-art
I kept the rest of the mechanism as untouched as possible, the new option is, well, optional, and defaults to the previous logic.
Before:
After:
