More granular incremental stats #3164
Merged
+89
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayhem
approved these changes
Feb 5, 2025
| @@ -91,11 +94,13 @@ def get_table_prefix(self) -> str: | |||
| def get_base_path(self) -> str: | |||
| return LISTENBRAINZ_POPULARITY_DIRECTORY | |||
|
|
|||
| def get_filter_aggregate_query(self, existing_aggregate: str, incremental_aggregate: str) -> str: | |||
| def get_filter_aggregate_query_coarse(self, existing_aggregate: str, incremental_aggregate: str, | |||
There was a problem hiding this comment.
this function has the same name as the one above. Intended?
There was a problem hiding this comment.
There are two classes in this file, so once in each.
Currently, the entirety of incremental dumps is checked to filter entities whose stats/popularity needs to be recomputed. This can be further optimized by storing the latest created timestamp of the listens in incremental dumps when a stat is run. The next time a stat is run, only listens with a higher created value (added through newer incremental dumps) are considered for the filter. Note that the incremental aggregate is still computed from all of incremental listens dump, only the filter is made more granular.
amCap1712
force-pushed
the
popularity-incremental-granular
branch
from
08be738 to
3d9ed9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the entirety of incremental dumps is checked to filter entities whose stats/popularity needs to be recomputed. This can be further optimized by storing the latest created timestamp of the listens in incremental dumps when a stat is
run. The next time a stat is run, only listens with a higher created value (added through newer incremental dumps) are considered for the filter.
Note that the incremental aggregate is still computed from all of incremental listens dump, only the filter is made more granular.