fix: Update rag examples to use fresh faiss index every time #998
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardikjshah
requested review from
ashwinb,
yanxi0830,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721 and
ehhuang
as code owners
facebook-github-bot
added
the
CLA Signed
hardikjshah
changed the title
ashwinb
reviewed
Feb 7, 2025
| @@ -1673,7 +1674,7 @@ | |||
| " for i, url in enumerate(urls)\n", | |||
| "]\n", | |||
| "\n", | |||
| "vector_db_id = \"test-vector-db\"\n", | |||
| "vector_db_id = f\"test-vector-db-{uuid.uuid4().hex}\"\n", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In several examples we use the same faiss index , which means running it multiple times fills up the index with duplicates which eventually degrades the model performance on RAG as multiple copies of the same irrelevant chunks might be picked up several times.
Fix is to ensure we create a new index each time.
Resolves issue in this discussion - #995
Test Plan
Re-ran the getting started guide multiple times to see the same output