Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Updating wording and nits in the README.md #992

Merged
merged 1 commit into from
Feb 11, 2025
Merged

docs: Updating wording and nits in the README.md #992

merged 1 commit into from
Feb 11, 2025

Conversation

kelbrown20
Copy link
Contributor

@kelbrown20 kelbrown20 commented Feb 6, 2025 •
edited
Loading

What does this PR do?

Fixing some wording nits and added small formatting suggestions in the README.md

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 6, 2025
booxter
booxter reviewed Feb 6, 2025
View reviewed changes
terrytangyuan
terrytangyuan reviewed Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar changes might be needed in the website as well https://github.com/meta-llama/llama-stack/tree/main/docs

ashwinb
ashwinb requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments inline

@raghotham raghotham changed the title [Docs] Updating wording and nits in the README.md docs: Updating wording and nits in the README.md Feb 7, 2025
raghotham
raghotham reviewed Feb 7, 2025
View reviewed changes
@kelbrown20
Copy link
Contributor Author

@ashwinb @raghotham Hello! Thank you for all the feedback, is there anything else that this PR needs before it can get merged in?

@terrytangyuan
Copy link
Collaborator

Thank you for improving this!

@terrytangyuan terrytangyuan merged commit d947ddd into meta-llama:main Feb 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghotham raghotham raghotham approved these changes

@ashwinb ashwinb ashwinb approved these changes

@booxter booxter booxter approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

@ehhuang ehhuang Awaiting requested review from ehhuang ehhuang is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kelbrown20 @terrytangyuan @ashwinb @booxter @raghotham @facebook-github-bot