Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix precommit check after moving to ruff #927

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Fix precommit check after moving to ruff #927

merged 1 commit into from
Feb 2, 2025

Conversation

terrytangyuan
Copy link
Collaborator

@terrytangyuan terrytangyuan commented Feb 2, 2025 •
edited
Loading

Lint check in main branch is failing. This fixes the lint check after we moved to ruff in #921. We need to move to a ruff.toml file as well as fixing and ignoring some additional checks.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 2, 2025
@terrytangyuan terrytangyuan changed the title Fix lint check after moving to ruff Fix precommit check after moving to ruff Feb 2, 2025
ashwinb
ashwinb approved these changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow thank you so much. I tried to fix it a bunch before yesterday but could not figure out why this was happening.

@ashwinb
Copy link
Contributor

ashwinb commented Feb 2, 2025

patched and tested once locally by running pre-commit run --files llama_stack/**/*.py

@ashwinb ashwinb merged commit 34ab7a3 into meta-llama:main Feb 2, 2025
2 checks passed
@terrytangyuan terrytangyuan deleted the fix-lint-ruff branch February 2, 2025 15:55
@terrytangyuan
Copy link
Collaborator Author

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinb ashwinb ashwinb approved these changes

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

@ehhuang ehhuang Awaiting requested review from ehhuang ehhuang is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrytangyuan @ashwinb @facebook-github-bot