Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report generation minor fixes #884

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Report generation minor fixes #884

merged 1 commit into from
Jan 28, 2025

Conversation

sixianyi0721
Copy link
Contributor

@sixianyi0721 sixianyi0721 commented Jan 27, 2025 •
edited
Loading

What does this PR do?

fixed report generation:

  1. do not initialize a new client in report.py - instead get it from pytest fixture
  2. Add "provider" for "safety" and "agents" section
  3. add logprobs functionality in "inference" section

Test Plan

See the regenerated report

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 27, 2025
@sixianyi0721 sixianyi0721 changed the title Fixreport Report generation minor fixes Jan 27, 2025
@sertrujilloo
Copy link

Merci

@sixianyi0721 sixianyi0721 changed the base branch from dockertest to main January 27, 2025 22:33
@sixianyi0721 sixianyi0721 marked this pull request as ready for review January 27, 2025 22:35
ashwinb
ashwinb approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@ashwinb ashwinb merged commit ba453c3 into main Jan 28, 2025
2 checks passed
@ashwinb ashwinb deleted the fixreport branch January 28, 2025 12:58
@MarcelF807 MarcelF807 mentioned this pull request Feb 1, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinb ashwinb ashwinb approved these changes

@MarcelF807 MarcelF807 MarcelF807 approved these changes

@sertrujilloo sertrujilloo sertrujilloo approved these changes

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sixianyi0721 @sertrujilloo @ashwinb @MarcelF807 @facebook-github-bot