Update discriminator to have the correct mapping
#881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinb
requested review from
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic and
sixianyi0721
as code owners
facebook-github-bot
added
the
CLA Signed
ashwinb
commented
Jan 26, 2025
| class ResponseFormatType(Enum): | ||
| json_schema = "json_schema" | ||
| grammar = "grammar" | ||
|
|
||
|
|
||
| @json_schema_type |
There was a problem hiding this comment.
also this should end up fixing the jsonschema related issues encountered in kotlin
ashwinb
force-pushed
the
better_openapi
branch
from
0ad9ce2 to
4b7efd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://swagger.io/docs/specification/v3_0/data-models/inheritance-and-polymorphism/#discriminator
When specifying discriminators, mapping must be specified unless the value of the discriminator is the subtype itself (which in our case is not.)
The changes in the YAML are self-explanatory.