Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] fix inference sdk test for v1 #775

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[bugfix] fix inference sdk test for v1 #775

merged 1 commit into from
Jan 15, 2025

Conversation

yanxi0830
Copy link
Contributor

@yanxi0830 yanxi0830 commented Jan 15, 2025 •
edited
Loading

What does this PR do?

  • fixes client sdk tests

Test Plan

LLAMA_STACK_BASE_URL="http://localhost:5000" pytest -v tests/client-sdk/inference/test_inference.py
image

Sources

Please link relevant resources if necessary.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 15, 2025
@yanxi0830 yanxi0830 marked this pull request as ready for review January 15, 2025 23:50
@yanxi0830 yanxi0830 merged commit 3e518c0 into main Jan 15, 2025
2 checks passed
@yanxi0830 yanxi0830 deleted the fix_client_sdk_inference branch January 15, 2025 23:52
vladimirivic
vladimirivic reviewed Jan 15, 2025
View reviewed changes
tests/client-sdk/inference/test_inference.py
text_content, tool_invocation_content = extract_tool_invocation_content(response)

tool_invocation_content = extract_tool_invocation_content(response)
print(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanxi0830 print()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirivic vladimirivic vladimirivic left review comments

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanxi0830 @vladimirivic @facebook-github-bot