Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase eval test w/ tool_runtime fixtures #773

Merged
merged 3 commits into from
Jan 15, 2025
Merged

rebase eval test w/ tool_runtime fixtures #773

merged 3 commits into from
Jan 15, 2025

Conversation

yanxi0830
Copy link
Contributor

@yanxi0830 yanxi0830 commented Jan 15, 2025

What does this PR do?

  • fix eval tests to include tool_runtime fixtures
  • rebase eval for extracting memory retrieval context

Test Plan

pytest -v -s -m meta_reference_eval_together_inference_huggingface_datasetio llama_stack/providers/tests/eval/test_eval.py
pytest -v -s -m braintrust_scoring_together_inference llama_stack/providers/tests/scoring/test_scoring.py

Sources

Please link relevant resources if necessary.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 15, 2025
@yanxi0830 yanxi0830 marked this pull request as ready for review January 15, 2025 20:09
@yanxi0830 yanxi0830 merged commit 6deef1e into main Jan 15, 2025
2 checks passed
@yanxi0830 yanxi0830 deleted the fix_eval_test branch January 15, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants