Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve model download doc #748

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Improve model download doc #748

merged 1 commit into from
Jan 13, 2025

Conversation

SLR722
Copy link
Contributor

@SLR722 SLR722 commented Jan 13, 2025

context

The documentation around model download from meta source part https://llama-stack.readthedocs.io/en/latest/references/llama_cli_reference/index.html#downloading-from-meta confused me and another colleague because we met issue during downloading.

After some debugging, I found that we need to quote META_URL in the command. To avoid other users have the same confusion, I updated the doc tor make it more clear

test

before
Screenshot 2025-01-12 at 11 48 37 PM

after
Screenshot 2025-01-12 at 11 40 02 PM

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 13, 2025
@SLR722 SLR722 marked this pull request as ready for review January 13, 2025 07:45
@raghotham raghotham merged commit 78727aa into main Jan 13, 2025
2 checks passed
@raghotham raghotham deleted the better_doc branch January 13, 2025 08:39
@yanxi0830 yanxi0830 mentioned this pull request Jan 13, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants