Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert back to model descriptor for model in list --downloaded #1201

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Feb 21, 2025

What does this PR do?

[Provide a short summary of what this PR does and why. Link to relevant issues if applicable.]

Currently , model in --downloaded just use the directory(already replace :), so covert back to descriptor keep the same with llama model list, and remove command also use descriptor.

before:
$ llama model list --downloaded
+-------------------------------------+----------+---------------------+
| Model                               | Size     | Modified Time       |
+-------------------------------------+----------+---------------------+
| Llama3.2-1B-Instruct-int4-qlora-eo8 | 1.53 GB  | 2025-02-20 16:32:49 |
+-------------------------------------+----------+---------------------+

after:
$ llama model list --downloaded
+-------------------------------------+----------+---------------------+
| Model                               | Size     | Modified Time       |
+-------------------------------------+----------+---------------------+
| Llama3.2-1B-Instruct:int4-qlora-eo8 | 1.53 GB  | 2025-02-20 16:32:49 |
+-------------------------------------+----------+---------------------+

Test Plan

[Describe the tests you ran to verify your changes with result summaries. Provide clear instructions so the plan can be easily re-executed.]

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 21, 2025
@reidliu41 reidliu41 force-pushed the covert-back-to-descriptor branch from d42501b to d8c65cc Compare February 21, 2025 08:53
@reidliu41 reidliu41 changed the title convert back to model descriptor for model in list --downloaded fix: convert back to model descriptor for model in list --downloaded Feb 21, 2025
@ashwinb ashwinb merged commit 9898589 into meta-llama:main Feb 21, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants