Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Remove unused python-openapi and json-strong-typing in openapi_generator #1167

Merged
merged 2 commits into from
Feb 20, 2025
Merged

docs: Remove unused python-openapi and json-strong-typing in openapi_generator #1167

merged 2 commits into from
Feb 20, 2025

Conversation

terrytangyuan
Copy link
Collaborator

This is no longer required to generated API reference after 5e7904e

@terrytangyuan
docs: Remove json-strong-typing since it's no longer needed
1403b58 
This is no longer required to generated API reference after 5e7904e
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 20, 2025
ashwinb
ashwinb reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, good call. but you don't need python-openapi either?

@terrytangyuan terrytangyuan changed the title docs: Remove json-strong-typing since it's no longer needed docs: Remove unused python-openapi and json-strong-typing in openapi_generator Feb 20, 2025
@terrytangyuan
Copy link
Collaborator Author

Updated!

@ashwinb ashwinb merged commit 25cdab5 into main Feb 20, 2025
4 checks passed
@ashwinb ashwinb deleted the terrytangyuan-patch-1 branch February 20, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinb ashwinb ashwinb approved these changes

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

@ehhuang ehhuang Awaiting requested review from ehhuang ehhuang is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrytangyuan @ashwinb @facebook-github-bot