-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: llama stack build use UV_SYSTEM_PYTHON to install dependencies to system environment #1163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I wonder if we really need this additional complexity again. A proposal: if we just base our operation on the UV_SYSTEM_PYTHON
env variable? If that is set, we know we don't intend to create a separate venv -- this is the variable uv
has settled upon and we already use it in the notebook example?
ugh my bad, just realized I've been using |
Also, please update the PR summary also! |
@@ -73,11 +73,16 @@ run() { | |||
local env_name="$1" | |||
local pip_dependencies="$2" | |||
local special_pip_deps="$3" | |||
|
|||
if [ -n "${UV_SYSTEM_PYTHON:-}" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I missed this, but I think you need to initialize this before the set -euo pipefail
otherwise you will get a failure if this env var is not set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ${UV_SYSTEM_PYTHON:-} part will cover it, but just to be consistent: ca687d3
What does this PR do?
build_venv.sh
to install in a venv environment, which do not work on Colab notebook environmentThis PR
Use
UV_SYSTEM_PYTHON
to make sure dependencies are installed in current system environment. Which will be used in the Colab environment.Test Plan