Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable test_text_chat_completion_with_tool_choice_required for remote::vllm #1148

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

terrytangyuan
Copy link
Collaborator

What does this PR do?

This verifies that #1059 test passed for remote::vllm so I am removing the xfail here.

Test Plan

Test passed:

LLAMA_STACK_BASE_URL=http://localhost:5002 pytest -v tests/client-sdk/inference/test_text_inference.py::test_text_chat_completion_with_tool_choice_required 
=============================================================== test session starts ===============================================================
platform linux -- Python 3.10.16, pytest-8.3.4, pluggy-1.5.0 -- /home/yutang/.conda/envs/distribution-myenv/bin/python3.10
cachedir: .pytest_cache
rootdir: /home/yutang/repos/llama-stack
configfile: pyproject.toml
plugins: anyio-4.8.0
collected 1 item                                                                                                                                  

tests/client-sdk/inference/test_text_inference.py::test_text_chat_completion_with_tool_choice_required[meta-llama/Llama-3.1-8B-Instruct] PASSED [100%]

@ehhuang
Copy link
Contributor

ehhuang commented Feb 19, 2025

Thanks!

@terrytangyuan terrytangyuan merged commit a66b4c4 into meta-llama:main Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants