Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: remove prints in codebase #1146

Merged
merged 2 commits into from
Feb 19, 2025
Merged

style: remove prints in codebase #1146

merged 2 commits into from
Feb 19, 2025

Conversation

yanxi0830
Copy link
Contributor

@yanxi0830 yanxi0830 commented Feb 19, 2025 •
edited
Loading

What does this PR do?

  • replace prints in codebase with logger
  • update print_table to use rich Table

Test Plan

llama stack list-providers
image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 19, 2025
@yanxi0830 yanxi0830 marked this pull request as ready for review February 19, 2025 01:03
@yanxi0830 yanxi0830 added this to the v0.1.4 milestone Feb 19, 2025
@yanxi0830 yanxi0830 mentioned this pull request Feb 19, 2025
Merged
@ashwinb ashwinb merged commit 37cf60b into main Feb 19, 2025
4 checks passed
@ashwinb ashwinb deleted the remove_prints branch February 19, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinb ashwinb ashwinb approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

@ehhuang ehhuang Awaiting requested review from ehhuang ehhuang is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
v0.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@yanxi0830 @ashwinb @terrytangyuan @facebook-github-bot