Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rag-example): add provider_id to avoid llama_stack_client 400 error #1114

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

fulvius31
Copy link
Contributor

@fulvius31 fulvius31 commented Feb 14, 2025

What does this PR do?

Add provider_id to avoid errors using the rag example with llama_stack_client

llama_stack_client.BadRequestError: Error code: 400 - {'detail': 'Invalid value: No provider specified and multiple providers available. Please specify a provider_id.'}

Test Plan

[Describe the tests you ran to verify your changes with result summaries. Provide clear instructions so the plan can be easily re-executed.]

llama_stack_client.BadRequestError: Error code: 400 - {'detail': 'Invalid value: No provider specified and multiple providers available. Please specify a provider_id.'}
using llama_stack_client
@facebook-github-bot
Copy link

Hi @fulvius31!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 14, 2025
@yanxi0830 yanxi0830 added this to the v0.1.4 milestone Feb 14, 2025
@fulvius31 fulvius31 requested a review from yanxi0830 February 15, 2025 01:56
@fulvius31 fulvius31 changed the title Add provider_id="faiss" to avoid errors using the rag example with llama_stack_client Add provider_id to avoid errors using the rag example with llama_stack_client Feb 15, 2025
@yanxi0830
Copy link
Contributor

could you update the PR title to pass semantic PR title-check?

@fulvius31 fulvius31 changed the title Add provider_id to avoid errors using the rag example with llama_stack_client fix(rag-example): add provider_id to avoid llama_stack_client 400 error Feb 18, 2025
@fulvius31 fulvius31 requested a review from ehhuang February 18, 2025 18:32
@ashwinb ashwinb merged commit 9e03df9 into meta-llama:main Feb 19, 2025
3 checks passed
@fulvius31 fulvius31 deleted the provider_id branch February 19, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants