Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove :path in agents #1077

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix: remove :path in agents #1077

merged 1 commit into from
Feb 13, 2025

Conversation

yanxi0830
Copy link
Contributor

What does this PR do?

Remove :path in agents, we cannot have :path in params inside endpoints except last one

Test Plan

[Describe the tests you ran to verify your changes with result summaries. Provide clear instructions so the plan can be easily re-executed.]

llama stack run

@yanxi0830 yanxi0830 marked this pull request as ready for review February 13, 2025 18:01
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 13, 2025
@yanxi0830 yanxi0830 changed the title fix remove :path in agents fix: remove :path in agents Feb 13, 2025
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha yes of course

@yanxi0830 yanxi0830 merged commit 1527c30 into main Feb 13, 2025
3 of 4 checks passed
@yanxi0830 yanxi0830 deleted the agents_fix branch February 13, 2025 18:04
franciscojavierarceo pushed a commit to franciscojavierarceo/llama-stack that referenced this pull request Feb 14, 2025
# What does this PR do?

Remove :path in agents, we cannot have :path in params inside endpoints
except last one

## Test Plan
[Describe the tests you ran to verify your changes with result
summaries. *Provide clear instructions so the plan can be easily
re-executed.*]
```
llama stack run
```

[//]: # (## Documentation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants