Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken .retrieve call using identifier= #135

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

cdoern
Copy link
Contributor

@cdoern cdoern commented Feb 11, 2025

What does this PR do?

identifier is not a valid argument for retrieve but model_id is.

╰─ llama-stack-client models get meta-llama/Llama-3.2-3B-Instruct
╭────────────────────────────────────────────────────────────────────────────────────╮
│ Failed to get model details                                                        │
│                                                                                    │
│ Error Type: TypeError                                                              │
│ Details: ModelsResource.retrieve() got an unexpected keyword argument 'identifier' │
╰────────────────────────────────────────────────────────────────────────────────────╯

Test Plan

the error now is:

╰─ llama-stack-client models get meta-llama/Llama-3.2-3B-Instruct
╭────────────────────────────────────────────────────╮
│ Failed to get model details                        │
│                                                    │
│ Error Type: NotFoundError                          │
│ Details: Error code: 404 - {'detail': 'Not Found'} │
╰────────────────────────────────────────────────────╯

identifier is not a valid argument for `retreive` but model_id is.

Signed-off-by: Charlie Doern <[email protected]>
@cdoern cdoern changed the title fix: broken .retreive call using identifier= fix: broken .retrieve call using identifier= Feb 11, 2025
@yanxi0830
Copy link
Contributor

Thanks!

Filed an issue separately to address your new error: meta-llama/llama-stack#1038

@yanxi0830 yanxi0830 merged commit 626805a into meta-llama:main Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants