chore(precommit): add uv-sync hook #278
Open
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tumido
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham and
ehhuang
as code owners
facebook-github-bot
added
the
CLA Signed
|
|
CryptoIngenieur1
approved these changes
Feb 12, 2025
CryptoIngenieur1
approved these changes
Feb 12, 2025
ashwinb
reviewed
Feb 14, 2025
| @@ -48,6 +48,7 @@ repos: | |||
| hooks: | |||
| - id: uv-export | |||
| args: ["--frozen", "--no-hashes", "--no-emit-project"] | |||
| - id: uv-sync | |||
There was a problem hiding this comment.
while you are at it, can you update the args above to add --output-file=requirements.txt
Signed-off-by: Tomas Coufal <[email protected]>
Signed-off-by: Tomas Coufal <[email protected]>
Signed-off-by: Tomas Coufal <[email protected]>
tumido
force-pushed
the
add-uv-sync-to-precommit
branch
from
a426944 to
ebf0429
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomas Coufal [email protected]
When standing up a dev setup, I've discovered a mismatch between
pyproject.tomlanduv.lock- call touv sync --extra devresults in diff onuv.lock.It seems like during the last version bump, the
uv.lockwas not regenerated. This discrepancy can be mitigated by adding auv-synchook to the precommit (fcf8893). The same hook is already present in thellama-stackrepo so I guess it would be worth adding it here as well.After adding the hook, I've just ran
precommit run -aand discovered some discrepancies here and there, so I've fixed those in this PR as well (let me know if I should move them to a separate PR).This repo is also missing a precommit CI workflow, should I add that as well? Or would you prefer a separate PR?