-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/fix few typos #834
fix/fix few typos #834
Conversation
Hi @abassel! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
720a702
to
4a10683
Compare
4a10683
to
1d0dbb0
Compare
Thanks, that is great! I will be able to approve it once you review and accept Contributor License Agreement |
Just signed my CLA |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for multiple typo fixes.
@abassel Thanks so much for these updates! Unfortunately we were also doing a refactor of the repo in parallel and it might override your changes, would it be okay for you to send a new PR once this is in place? Note: We have just moved files around but not updated any typos :) |
I completely understand. I have been thru similar situations. You are welcome to drop the merged contribution and I will create a new one for the refactoring. Let me know what is the branch name that I should use. Thanks |
Many thanks and sorry for making you do the efforts again! This is the PR: #832 I would request waiting 1-2 days and updating the main directly incase we make any other follow up changes. I will give a ping in this thread once its cleared-we are planning to merge the branch today/tomorrow Thanks again for being so understanding! |
What does this PR do?
Fixes few typos
Feature/Issue validation/testing
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B
Before submitting
Pull Request section?
to it if that's the case.
Thanks for contributing 🎉!