Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/fix few typos #834

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

abassel
Copy link
Contributor

@abassel abassel commented Jan 10, 2025

  • fixed few typos

What does this PR do?

Fixes few typos

Feature/Issue validation/testing

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

@facebook-github-bot
Copy link

Hi @abassel!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@IgorKasianenko
Copy link
Contributor

Thanks, that is great! I will be able to approve it once you review and accept Contributor License Agreement

@IgorKasianenko IgorKasianenko self-assigned this Jan 10, 2025
@abassel
Copy link
Contributor Author

abassel commented Jan 11, 2025

Just signed my CLA

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Contributor

@IgorKasianenko IgorKasianenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for multiple typo fixes.

@IgorKasianenko IgorKasianenko merged commit 1521c5b into meta-llama:main Jan 13, 2025
1 check passed
@init27
Copy link
Contributor

init27 commented Jan 14, 2025

@abassel Thanks so much for these updates!

Unfortunately we were also doing a refactor of the repo in parallel and it might override your changes, would it be okay for you to send a new PR once this is in place?

Note: We have just moved files around but not updated any typos :)

@abassel
Copy link
Contributor Author

abassel commented Jan 14, 2025

I completely understand. I have been thru similar situations. You are welcome to drop the merged contribution and I will create a new one for the refactoring. Let me know what is the branch name that I should use. Thanks

@init27
Copy link
Contributor

init27 commented Jan 14, 2025

Many thanks and sorry for making you do the efforts again!

This is the PR: #832

I would request waiting 1-2 days and updating the main directly incase we make any other follow up changes. I will give a ping in this thread once its cleared-we are planning to merge the branch today/tomorrow

Thanks again for being so understanding!

@abassel abassel mentioned this pull request Jan 20, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants