Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wandb.py to accept setting run name from command line argument (e.g., --wandb_config.name "run_name") for fine tuning #772

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryf1123
Copy link

@ryf1123 ryf1123 commented Nov 4, 2024

What does this PR do?

Current wandb logging generate a random run name (despite wandb supporting assigning a run name); I added a missing name attribute to wandb_config, so one could use command line argument like this --wandb_config.name "run_name" to control the displayed run_name on the wandb webpage.

Feature/Issue validation/testing

Before and after the change of this commit, and use argument --wandb_config.name "fake run name". Note that stoic-eon-2 is a random name.

Screenshot 2024-11-04 at 15 43 29

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Sorry, something went wrong.

Add name attribute to wandb_config, so one could use command line argument like this `--wandb_config.name "run_name"` to control the displayed run_name on the wandb webpage
@facebook-github-bot
Copy link

Hi @ryf1123!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Contributor

@IgorKasianenko IgorKasianenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fix!

@IgorKasianenko IgorKasianenko self-assigned this Mar 4, 2025
@IgorKasianenko
Copy link
Contributor

@ryf1123 Please review and accept Contributor License Agreement at https://code.facebook.com/cla so I will be able to merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants