Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom dataset file #659

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Adding custom dataset file #659

merged 1 commit into from
Sep 3, 2024

Conversation

goswamig
Copy link
Contributor

@goswamig goswamig commented Sep 2, 2024

What does this PR do?

Fixes # (658)
The custom dataset file was removed probably by mistake during this PR #650

Feature/Issue validation/testing

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

@facebook-github-bot
Copy link

Hi @goswamig!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@goswamig
Copy link
Contributor Author

goswamig commented Sep 2, 2024

Without this

 >>> from llama_recipes.utils.dataset_utils import get_dataloader
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ubuntu/llama-recipes/src/llama_recipes/utils/__init__.py", line 5, in <module>
    from llama_recipes.utils.dataset_utils import *
  File "/home/ubuntu/llama-recipes/src/llama_recipes/utils/dataset_utils.py", line 7, in <module>
    from llama_recipes.datasets import DATASET_PREPROC, get_custom_dataset
  File "/home/ubuntu/llama-recipes/src/llama_recipes/datasets/__init__.py", line 8, in <module>
    from llama_recipes.datasets.custom_dataset import get_custom_dataset
ModuleNotFoundError: No module named 'llama_recipes.datasets.custom_dataset'

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@goswamig
Copy link
Contributor Author

goswamig commented Sep 3, 2024

@mreso Can you please take a look?

Copy link
Contributor

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the classic "new file missing from PR...."
Thanks for the fix! LGTM

@mreso mreso merged commit ccd4741 into meta-llama:main Sep 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants