Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable http header #28

Merged
merged 2 commits into from
May 8, 2020
Merged

Conversation

foosinn
Copy link
Contributor

@foosinn foosinn commented Apr 4, 2020

Hey,

not sure if this is wanted, but for on some apps the username header is not configurable. This pull-request allows to configure multipe headers.

@foosinn foosinn force-pushed the configurable-http-header branch from fd652dc to 07c26c8 Compare April 4, 2020 20:53
@mhrabovcin
Copy link
Contributor

@foosinn thanks for the contribution. What is the use of this new feature?

@foosinn
Copy link
Contributor Author

foosinn commented May 7, 2020

I was trying out radicale, which does not allow to configure the auth header. Maybe other applications are affected too?

Copy link
Contributor

@jr0d jr0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any harm in this.

internal/config.go Outdated Show resolved Hide resolved
@jr0d jr0d merged commit 870f904 into mesosphere:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants