Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid error log message #27

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

foosinn
Copy link
Contributor

@foosinn foosinn commented Apr 4, 2020

a run of go test ./... failed for me due to an invalid Errorf statement.

@k3a
Copy link

k3a commented May 6, 2020

You should probably use %v to make it consistent with other errors in the repo.
There doesn't seem to be difference now (https://play.golang.org/p/01OEs7caVsA) but I think there used to be difference in previous Go versions.

@foosinn
Copy link
Contributor Author

foosinn commented May 7, 2020

Updated to use %v

@mhrabovcin mhrabovcin requested a review from jr0d May 7, 2020 07:10
@mhrabovcin
Copy link
Contributor

@jr0d can we merge this one?

@jr0d jr0d merged commit 5d70c6f into mesosphere:master May 7, 2020
@jr0d
Copy link
Contributor

jr0d commented May 7, 2020

Thanks @foosinn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants