Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"groups session data is missing, re-authenticating" after adding groups to session #25

Closed
brokenjacobs opened this issue Mar 19, 2020 · 8 comments · Fixed by #29
Closed

Comments

@brokenjacobs
Copy link

Trying the v2 codebase since I push group claims from my IDP. And here is what happens on every auth request:
ime="2020-03-19T22:36:49Z" level=info msg="creating group claims session with groups: [WebApps.LCS.Access.User.Group K8S.LCS.Admin.User.Group]" source_ip=10.203.53.248 time="2020-03-19T22:36:49Z" level=info msg="groups session data is missing, re-authenticating" source_ip=10.203.53.248
I can verify the forward_auth_claims cookie is being set and sent in the browser, and I even tried renaming it, and it goes back and forth with the corrected name.

It seems like it is decoding the cooking into the session but getting a null value. I'm not sure how that is happening. Any clues?

@brokenjacobs
Copy link
Author

Turning up debug:
I see the cookie in:
level=debug msg="Handling callback" headers="....

But not in:
level=debug msg="Authenticate request" headers="

@brokenjacobs
Copy link
Author

Save the session:

if err := session.Save(r, w); err != nil {

Implementation:
func (f *fakeStore) Save(r *http.Request, w http.ResponseWriter, s *sessions.Session) error {

So... guessing this all doesn't work yet?

@brokenjacobs
Copy link
Author

ping?

@geiseri
Copy link

geiseri commented Apr 4, 2020

this seems like what i am seeing on #23

@brokenjacobs
Copy link
Author

looks like this shouldn't be a 'release' as the implementation is incomplete.

@jr0d
Copy link
Contributor

jr0d commented May 8, 2020

@brokenjacobs Sorry, I've been away from this for a while. Group sessions do work, though they require a SESSION_KEY to be set. We were not checking properly that the SESSION_KEY existed before setting up the group claims session; resulting in this behavior.

@jr0d jr0d closed this as completed in #29 May 8, 2020
@brokenjacobs
Copy link
Author

I hadn't checked back in but it looks like this has been resolved now? Yay!

@brokenjacobs
Copy link
Author

nope. added a SESSION_KEY setting 32 characters long, and it is still not working. Same error messages, on 2.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants