Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_forward_auth_claims doesn't respect domain cookie property #23

Closed
geiseri opened this issue Mar 3, 2020 · 1 comment · Fixed by #29
Closed

_forward_auth_claims doesn't respect domain cookie property #23

geiseri opened this issue Mar 3, 2020 · 1 comment · Fixed by #29

Comments

@geiseri
Copy link

geiseri commented Mar 3, 2020

It looks like the group's cookie is not respecting the domain so that it will not allow anything else to log in.
image
If I look at the server I see the logs below:
image

1161f0309308 is my idp, and c069e53d0118 is the auth docker. If you see the idp returns the groups correctly, and it looks like the cookie is properly populated. The issue is that chrome filters the cookie since its not associated with my whois domain. If I roll back to 1.0.4 (before the groups change) it works properly.

@jr0d
Copy link
Contributor

jr0d commented May 8, 2020

We we're not explicitly setting the cookie domain (if one is set) on the session cookie. The linked issue should correct this behavior.

@jr0d jr0d closed this as completed in #29 May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants