generated from d2iq-archive/golang-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add images and demo script for in-cluster registry #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used when utilising mindthegap to bootstrap an in-cluster registry.
This will be used when utilising mindthegap to bootstrap an in-cluster registry.
dkoshkin
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! ( worked locally for me after I figured out we're no longer using make :| )
For any further help, visit https://docs.cilium.io/en/v1.16/gettinghelp
node/self-hosted-registry-demo-control-plane condition met
node/self-hosted-registry-demo-worker condition met
NAME STATUS ROLES AGE VERSION
self-hosted-registry-demo-control-plane Ready control-plane 58s v1.27.3
self-hosted-registry-demo-worker Ready <none> 35s v1.27.3
pod "busybox" deleted
error: timed out waiting for the condition
Yay everything worked as expected - this was supposed to fail!
mhrabovcin
reviewed
Nov 5, 2024
dkoshkin
reviewed
Nov 5, 2024
dkoshkin
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great demo script!
Merged
jimmidyson
pushed a commit
that referenced
this pull request
Nov 11, 2024
🤖 I have created a release *beep* *boop* --- ## 1.17.0 (2024-11-11) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Add images and demo script for in-cluster registry by @jimmidyson in #801 * feat: Build with go 1.23.3 and upgrade all tools by @jimmidyson in #808 ### Fixes 🔧 * fix: Allow TLS to pull chart from OCI repository by @dlipovetsky in #804 * fix: Reload registry TLS certificate when it is updated on the file system by @dlipovetsky in #805 ## New Contributors * @dlipovetsky made their first contribution in #804 **Full Changelog**: v1.16.0...v1.17.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: mesosphere-actions-pr-bot[bot] <157582460+mesosphere-actions-pr-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would love it if someone would try it out locally and tell me it works for them too!