fix: Unset REGISTRY_ prefixed env vars #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
force-pushed
the
jimmi/D2IQ-97438-registry-envvars
branch
from
99f11df to
d162d3e
Compare
The Docker registry that is embedded in mindthegap reads `REGISTRY_` prefixed environment variables, which could lead to unexpected behaviour dependin on the environment. This commit unsets these environment variables to ensure consistent behaviour independent of environment. Fixes D2IQ-97438.
jimmidyson
force-pushed
the
jimmi/D2IQ-97438-registry-envvars
branch
from
d162d3e to
ccaf0ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker registry that is embedded in mindthegap reads
REGISTRY_prefixedenvironment variables, which could lead to unexpected behaviour depending on
the environment. This commit unsets these environment variables to ensure
consistent behaviour independent of environment.
Fixes D2IQ-97438.