Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support passing optional scheme in --to-registry #252

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Nov 2, 2022

Fixes #251

  • Allows to reuse env var with the registry URI with a scheme.
  • Support passing http scheme in --to-registry instead of setting --to-registry-insecure-skip-tls-verify.

@dkoshkin dkoshkin requested a review from jimmidyson November 2, 2022 05:12
@dkoshkin dkoshkin self-assigned this Nov 2, 2022
@dkoshkin dkoshkin force-pushed the dkoshkin/http-registry branch 5 times, most recently from 1bc5765 to daeefe3 Compare November 3, 2022 13:45
Allows to reuse env var with the registry URI with a scheme.
Also supports passing http instead of --to-registry-insecure-skip-tls-verify.
@jimmidyson jimmidyson force-pushed the dkoshkin/http-registry branch from daeefe3 to 6a149a7 Compare November 7, 2022 16:29
@jimmidyson jimmidyson enabled auto-merge (squash) November 7, 2022 16:48
@jimmidyson jimmidyson merged commit 6983970 into main Nov 7, 2022
@jimmidyson jimmidyson deleted the dkoshkin/http-registry branch November 7, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry flag should accept protocol
3 participants