Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure that image IDs do not change on import #185

Merged
merged 1 commit into from
Sep 14, 2022
Merged

fix: Ensure that image IDs do not change on import #185

merged 1 commit into from
Sep 14, 2022

Conversation

jimmidyson
Copy link
Contributor

No description provided.

@jimmidyson jimmidyson requested a review from dkoshkin September 14, 2022 12:52
@github-actions github-actions bot added the fix label Sep 14, 2022
@jimmidyson jimmidyson merged commit 80f7e5b into main Sep 14, 2022
@jimmidyson jimmidyson deleted the jimmi/fix-import-image-ids branch September 14, 2022 13:15
@github-actions github-actions bot mentioned this pull request Sep 14, 2022
Merged
@dkoshkin
Copy link
Contributor

Verified aswell

With the old version of mindthegap (notice 1ab1e088dd13b ID):

[root@ip-172-31-15-73 images]# ./mindthegap import image-bundle --image-bundle kubernetes-images-1.24.4-d2iq.1-fips.tar
 ✓ Creating temporary directory
 ✓ Unarchiving image bundle "kubernetes-images-1.24.4-d2iq.1-fips.tar"
 ✓ Parsing image bundle config
 ✓ Starting temporary Docker registry
 ✓ Importing docker.io/mesosphere/etcd:v3.4.13_fips.0
 ✓ Importing docker.io/mesosphere/kube-apiserver:v1.24.4_fips.0
 ✓ Importing docker.io/mesosphere/kube-controller-manager:v1.24.4_fips.0
 ✓ Importing docker.io/mesosphere/kube-proxy:v1.24.4_fips.0
 ✓ Importing docker.io/mesosphere/kube-scheduler:v1.24.4_fips.0
 ✓ Importing docker.io/mesosphere/pause:3.7
 ✓ Importing k8s.gcr.io/coredns/coredns:v1.8.6
 ✓ Importing k8s.gcr.io/pause:3.2
[root@ip-172-31-15-73 images]# crictl images
IMAGE                                          TAG                 IMAGE ID            SIZE
docker.io/mesosphere/kube-apiserver            v1.24.4_fips.0      1ab1e088dd13b       33.8MB

With this fix its the correct b7c51f9294349 ID.

[root@ip-172-31-15-73 images]# ./mindthegap import image-bundle --image-bundle kubernetes-images-1.24.4-d2iq.1-fips.tar
 ✓ Creating temporary directory
 ✓ Unarchiving image bundle "kubernetes-images-1.24.4-d2iq.1-fips.tar"
 ✓ Parsing image bundle config
 ✓ Starting temporary Docker registry
 ✓ Importing docker.io/mesosphere/etcd:v3.4.13_fips.0
 ✓ Importing docker.io/mesosphere/kube-apiserver:v1.24.4_fips.0
 ✓ Importing docker.io/mesosphere/kube-controller-manager:v1.24.4_fips.0
 ✓ Importing docker.io/mesosphere/kube-proxy:v1.24.4_fips.0
 ✓ Importing docker.io/mesosphere/kube-scheduler:v1.24.4_fips.0
 ✓ Importing docker.io/mesosphere/pause:3.7
 ✓ Importing k8s.gcr.io/coredns/coredns:v1.8.6
 ✓ Importing k8s.gcr.io/pause:3.2
[root@ip-172-31-15-73 images]# crictl images
IMAGE                                          TAG                 IMAGE ID            SIZE
docker.io/mesosphere/kube-apiserver            v1.24.4_fips.0      b7c51f9294349       131MB

dkoshkin added a commit to mesosphere/konvoy-image-builder that referenced this pull request Sep 14, 2022
@dkoshkin
fix: bump mindthegap that preserves image IDs
3b8e930 
This version comes with mesosphere/mindthegap#185
@dkoshkin dkoshkin mentioned this pull request Sep 14, 2022
Merged
supershal pushed a commit to mesosphere/konvoy-image-builder that referenced this pull request Sep 14, 2022
@dkoshkin
fix: bump mindthegap to preserves image IDs (#500)
b58c969 
* fix: bump mindthegap that preserves image IDs

This version comes with mesosphere/mindthegap#185

* use mindthegap v1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoshkin dkoshkin Awaiting requested review from dkoshkin

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmidyson @dkoshkin