Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent 404 on ECR during image creation #100

Merged
merged 2 commits into from
Apr 25, 2022
Merged

fix: prevent 404 on ECR during image creation #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca757c1
feat: introduces no-tags option for inspect
tillt Apr 22, 2022
8d1ff51
feat: ignore tags when inspecting
tillt Apr 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/create/imagebundle/image_bundle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ func NewCommand(out output.Output) *cobra.Command {
srcImageManifestList, skopeoStdout, skopeoStderr, err := skopeoRunner.InspectManifest(
context.Background(),
fmt.Sprintf("%s%s", srcSkopeoScheme, srcImageName),
skopeo.NoTags(),
)
if err != nil {
srcSkopeoScheme = "docker-daemon:"
Expand Down
6 changes: 6 additions & 0 deletions skopeo/skopeo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,12 @@ func All() SkopeoOption {
}
}

func NoTags() SkopeoOption {
return func() string {
return "--no-tags"
}
}

func IndexOnly() SkopeoOption {
return func() string {
return "--multi-arch=index-only"
Expand Down