fix: prevent 404 on ECR during image creation #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillt
changed the title
|
Validated with a Kaptain image list; Overall the performance increased by about 30%. |
jimmidyson
force-pushed
the
till/ecr-exclusion
branch
from
0b25ab6 to
8d1ff51
Compare
jimmidyson
approved these changes
Apr 25, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
* feat: introduces no-tags option for inspect * feat: ignore tags when inspecting (cherry picked from commit e000ef7)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jimmidyson
pushed a commit
that referenced
this pull request
Apr 25, 2022
* feat: introduces no-tags option for inspect * feat: ignore tags when inspecting (cherry picked from commit e000ef7) Signed-off-by: Jimmi Dyson <[email protected]>
jimmidyson
pushed a commit
that referenced
this pull request
Apr 25, 2022
* feat: introduces no-tags option for inspect * feat: ignore tags when inspecting (cherry picked from commit e000ef7) Signed-off-by: Jimmi Dyson <[email protected]>
jimmidyson
pushed a commit
that referenced
this pull request
Apr 25, 2022
* feat: introduces no-tags option for inspect * feat: ignore tags when inspecting (cherry picked from commit e000ef7) Signed-off-by: Jimmi Dyson <[email protected]> Co-authored-by: Till Toenshoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the inspect function on ECR repositories, it fails with an ominous 404.
containers/skopeo#1230
This skips all extended tag listing -- we are happy with the one we asked for which IIUC should not be any problem for the functionality of mindthegap.