-
Notifications
You must be signed in to change notification settings - Fork 3
Update to latest release, drop the chown #56
Conversation
friendly ping @nfnt and @ANeumann82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we chown'd in the first place, but I assume it now works without it. We do have an IT for this, so if it's green i'm fine :)
@ANeumann82 the reason is explained in the comments linked from this PR's description.
Yeah, although it's not that robust unfortunately. |
A-ha!
💥 |
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)): ``` porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter Unable to find image 'criteord/cassandra_exporter:2.3.2' locally 2.3.2: Pulling from criteord/cassandra_exporter bc51dd8edc1b: Pull complete d1d06863bb82: Pull complete adf4d10a782b: Pull complete 7db4424ff270: Pull complete e008a301333c: Pull complete 10121b885a52: Pull complete 0d34188e8091: Pull complete fc3c7604e1c5: Pull complete 019737f36353: Pull complete a26e5d6f647b: Pull complete 3b6b59aecfbd: Pull complete Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3 Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2 total 4760 -rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar porridge@beczulka:~$ ``` We actually bump to 2.3.3 since the earlier one was non-functional. Also rename a parameter in cassandra config as the old one is not recognized.
OK, this was an adventure but it looks like I got it working in the end. |
Turns out they made yet another release after me reporting the issue, so now I backed out these new changes. Merging. |
The permissions are now fixed in upstream repo, so we can drop the chown: