Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Update to latest release, drop the chown #56

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Update to latest release, drop the chown #56

merged 2 commits into from
Mar 4, 2020

Conversation

porridge
Copy link
Contributor

The permissions are now fixed in upstream repo, so we can drop the chown:

porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter
Unable to find image 'criteord/cassandra_exporter:2.3.2' locally
2.3.2: Pulling from criteord/cassandra_exporter
bc51dd8edc1b: Pull complete 
d1d06863bb82: Pull complete 
adf4d10a782b: Pull complete 
7db4424ff270: Pull complete 
e008a301333c: Pull complete 
10121b885a52: Pull complete 
0d34188e8091: Pull complete 
fc3c7604e1c5: Pull complete 
019737f36353: Pull complete 
a26e5d6f647b: Pull complete 
3b6b59aecfbd: Pull complete 
Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3
Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2
total 4760
-rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar
porridge@beczulka:~$ 

@porridge
Copy link
Contributor Author

friendly ping @nfnt and @ANeumann82

Copy link
Contributor

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we chown'd in the first place, but I assume it now works without it. We do have an IT for this, so if it's green i'm fine :)

CHANGELOG.md Outdated Show resolved Hide resolved
@porridge
Copy link
Contributor Author

I'm not sure why we chown'd in the first place, but I assume it now works without it.

@ANeumann82 the reason is explained in the comments linked from this PR's description.

We do have an IT for this, so if it's green i'm fine :)

Yeah, although it's not that robust unfortunately.

@porridge
Copy link
Contributor Author

porridge commented Mar 3, 2020

A-ha!

[main] INFO com.criteo.nosql.cassandra.exporter.Config - Loading yaml config from /etc/cassandra_exporter/config.yml
[main] ERROR com.criteo.nosql.cassandra.exporter.Config - Cannot load config file
com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "maxScrapFrequencyInSec" (class com.criteo.nosql.cassandra.exporter.Config), not marked as ignorable (9 known properties: "host", "additionalLabelsFromEnvvars", "user", "ssl", "blacklist", "listenPort", "password", "listenAddress", "maxScrapeFrequencyInSec"])
 at [Source: (File); line: 50, column: 3] (through reference chain: com.criteo.nosql.cassandra.exporter.Config["maxScrapFrequencyInSec"])

💥

The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)):
```
porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter
Unable to find image 'criteord/cassandra_exporter:2.3.2' locally
2.3.2: Pulling from criteord/cassandra_exporter
bc51dd8edc1b: Pull complete
d1d06863bb82: Pull complete
adf4d10a782b: Pull complete
7db4424ff270: Pull complete
e008a301333c: Pull complete
10121b885a52: Pull complete
0d34188e8091: Pull complete
fc3c7604e1c5: Pull complete
019737f36353: Pull complete
a26e5d6f647b: Pull complete
3b6b59aecfbd: Pull complete
Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3
Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2
total 4760
-rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar
porridge@beczulka:~$
```

We actually bump to 2.3.3 since the earlier one was non-functional.

Also rename a parameter in cassandra config as the old one is not
recognized.
@porridge
Copy link
Contributor Author

porridge commented Mar 3, 2020

OK, this was an adventure but it looks like I got it working in the end.
PTAL @ANeumann82 since there are some new changes.

@porridge
Copy link
Contributor Author

porridge commented Mar 4, 2020

Turns out they made yet another release after me reporting the issue, so now I backed out these new changes. Merging.

@porridge porridge merged commit 8af4817 into master Mar 4, 2020
@porridge porridge deleted the drop-chown branch March 4, 2020 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants