Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give read permissions to non-root #68

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Give read permissions to non-root #68

merged 1 commit into from
Feb 6, 2020

Conversation

porridge
Copy link
Contributor

@porridge porridge commented Feb 5, 2020

Without this it's hard to run the exporter as non-root.
Also, there is no need to give the executable bit to regular files, the capital X should be enough.

@porridge
Give read permissions to non-root
ddc4c13 
Without this it's hard to run the exporter as non-root.
Also, there is no need to give the executable bit to regular files, the capital `X` should be enough.
@porridge porridge mentioned this pull request Feb 5, 2020
Merged
@geobeau
Copy link
Contributor

geobeau commented Feb 6, 2020

Hello, thank you for the PR

@geobeau geobeau merged commit e8a78a8 into criteo:master Feb 6, 2020
porridge added a commit to d2iq-archive/kudo-cassandra-operator that referenced this pull request Feb 19, 2020
@porridge
Update to latest release, drop the chown
0cc697c 
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)):
```
porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter
Unable to find image 'criteord/cassandra_exporter:2.3.2' locally
2.3.2: Pulling from criteord/cassandra_exporter
bc51dd8edc1b: Pull complete 
d1d06863bb82: Pull complete 
adf4d10a782b: Pull complete 
7db4424ff270: Pull complete 
e008a301333c: Pull complete 
10121b885a52: Pull complete 
0d34188e8091: Pull complete 
fc3c7604e1c5: Pull complete 
019737f36353: Pull complete 
a26e5d6f647b: Pull complete 
3b6b59aecfbd: Pull complete 
Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3
Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2
total 4760
-rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar
porridge@beczulka:~$ 
```
@porridge porridge mentioned this pull request Feb 19, 2020
Merged
porridge added a commit to d2iq-archive/kudo-cassandra-operator that referenced this pull request Feb 21, 2020
@porridge
Update to latest release, drop the chown
4eed5dd 
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)):
```
porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter
Unable to find image 'criteord/cassandra_exporter:2.3.2' locally
2.3.2: Pulling from criteord/cassandra_exporter
bc51dd8edc1b: Pull complete 
d1d06863bb82: Pull complete 
adf4d10a782b: Pull complete 
7db4424ff270: Pull complete 
e008a301333c: Pull complete 
10121b885a52: Pull complete 
0d34188e8091: Pull complete 
fc3c7604e1c5: Pull complete 
019737f36353: Pull complete 
a26e5d6f647b: Pull complete 
3b6b59aecfbd: Pull complete 
Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3
Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2
total 4760
-rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar
porridge@beczulka:~$ 
```
porridge added a commit to d2iq-archive/kudo-cassandra-operator that referenced this pull request Mar 3, 2020
@porridge
Update to latest release, drop the chown
76d1644 
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)):
```
porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter
Unable to find image 'criteord/cassandra_exporter:2.3.2' locally
2.3.2: Pulling from criteord/cassandra_exporter
bc51dd8edc1b: Pull complete
d1d06863bb82: Pull complete
adf4d10a782b: Pull complete
7db4424ff270: Pull complete
e008a301333c: Pull complete
10121b885a52: Pull complete
0d34188e8091: Pull complete
fc3c7604e1c5: Pull complete
019737f36353: Pull complete
a26e5d6f647b: Pull complete
3b6b59aecfbd: Pull complete
Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3
Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2
total 4760
-rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar
porridge@beczulka:~$
```
We actually bump to 2.3.3 since the earlier one was non-functional.
porridge added a commit to d2iq-archive/kudo-cassandra-operator that referenced this pull request Mar 3, 2020
@porridge
Update cassandra exporter to latest release.
82c7564 
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)):
```
porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter
Unable to find image 'criteord/cassandra_exporter:2.3.2' locally
2.3.2: Pulling from criteord/cassandra_exporter
bc51dd8edc1b: Pull complete
d1d06863bb82: Pull complete
adf4d10a782b: Pull complete
7db4424ff270: Pull complete
e008a301333c: Pull complete
10121b885a52: Pull complete
0d34188e8091: Pull complete
fc3c7604e1c5: Pull complete
019737f36353: Pull complete
a26e5d6f647b: Pull complete
3b6b59aecfbd: Pull complete
Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3
Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2
total 4760
-rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar
porridge@beczulka:~$
```

We actually bump to 2.3.3 since the earlier one was non-functional.

Also rename a parameter in cassandra config as the old one is not
recognized.
porridge added a commit to d2iq-archive/kudo-cassandra-operator that referenced this pull request Mar 3, 2020
@porridge
Update cassandra exporter to latest release.
e02e255 
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)):
```
porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter
Unable to find image 'criteord/cassandra_exporter:2.3.2' locally
2.3.2: Pulling from criteord/cassandra_exporter
bc51dd8edc1b: Pull complete
d1d06863bb82: Pull complete
adf4d10a782b: Pull complete
7db4424ff270: Pull complete
e008a301333c: Pull complete
10121b885a52: Pull complete
0d34188e8091: Pull complete
fc3c7604e1c5: Pull complete
019737f36353: Pull complete
a26e5d6f647b: Pull complete
3b6b59aecfbd: Pull complete
Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3
Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2
total 4760
-rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar
porridge@beczulka:~$
```

We actually bump to 2.3.3 since the earlier one was non-functional.

Also rename a parameter in cassandra config as the old one is not
recognized.
porridge added a commit to d2iq-archive/kudo-cassandra-operator that referenced this pull request Mar 4, 2020
@porridge
Update to latest release, drop the chown (#56)
8af4817 
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)):
```
porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter
Unable to find image 'criteord/cassandra_exporter:2.3.2' locally
2.3.2: Pulling from criteord/cassandra_exporter
bc51dd8edc1b: Pull complete
d1d06863bb82: Pull complete
adf4d10a782b: Pull complete
7db4424ff270: Pull complete
e008a301333c: Pull complete
10121b885a52: Pull complete
0d34188e8091: Pull complete
fc3c7604e1c5: Pull complete
019737f36353: Pull complete
a26e5d6f647b: Pull complete
3b6b59aecfbd: Pull complete
Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3
Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2
total 4760
-rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar
porridge@beczulka:~$
```

We actually bump to 2.3.4 since there were other problems with 2.3.2 and 2.3.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@porridge @geobeau