Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

cert-manager/fluentbit: upgrade-strategy delete #574

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Oct 5, 2020

What type of PR is this?

Bug

What this PR does/ why we need it:

The Deployment selectors changed for fluentbit and cert-manager, need to use the delete upgrade-strategy.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- cert-manager: The Deployment selectors were changed, use `delete` `upgrade-strategy`.
- fluentbit: The Deployment selectors were changed, use `delete` `upgrade-strategy`.

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@dkoshkin dkoshkin requested review from a team as code owners October 5, 2020 20:13
Copy link
Contributor

@gracedo gracedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the catalog.kubeaddons.mesosphere.io/addon-revision's, otherwise lgtm!

@dkoshkin dkoshkin force-pushed the dkoshkin-upgrade-delete branch from bf04a12 to 40de466 Compare October 5, 2020 20:37
@dkoshkin dkoshkin requested a review from gracedo October 5, 2020 20:38
@dkoshkin
Copy link
Contributor Author

dkoshkin commented Oct 5, 2020

Tested locally by upgrading from Konvoy v1.5.2 to this with https://github.com/mesosphere/kubeaddons/pull/1017

➜ helm3 list -a -A
NAME                                     	NAMESPACE   	REVISION	UPDATED                                	STATUS  	CHART                       	APP VERSION
cert-manager-kubeaddons                  	cert-manager	1       	2020-10-05 20:50:00.179778921 +0000 UTC	deployed	cert-manager-setup-0.1.17   	0.10.1
fluentbit-kubeaddons                     	kubeaddons  	1       	2020-10-05 20:48:28.866147081 +0000 UTC	deployed	fluent-bit-0.7.1            	1.5.6
➜  k logs -n kubeaddons     kubeaddons-controller-manager-898959d54-6965r | grep "upgrade strategy:"
2020-10-05T20:48:24.864Z	INFO	kubeaddons-controller.Addon.Helm3.Deploy	upgrade strategy: "delete", will perform cleanup first	{"Addon": "fluentbit", "namespace": "kubeaddons", "chart": "fluent-bit", "addon": "fluentbit", "version": "0.7.1", "valuesCRC32": "4ed54791"}
2020-10-05T20:49:10.398Z	INFO	kubeaddons-controller.Addon.Helm3.Deploy	upgrade strategy: "delete", will perform cleanup first	{"ClusterAddon": "cert-manager", "namespace": "cert-manager", "chart": "cert-manager-setup", "addon": "cert-manager", "version": "0.1.17", "valuesCRC32": "d4b07319"}
2020-10-05T20:49:58.518Z	INFO	kubeaddons-controller.Addon.Helm3.Deploy	upgrade strategy: "delete", will perform cleanup first	{"ClusterAddon": "cert-manager", "namespace": "cert-manager", "chart": "cert-manager-setup", "addon": "cert-manager", "version": "0.1.17", "valuesCRC32": "d4b07319"}

@joejulian joejulian merged commit a826617 into master Oct 5, 2020
@joejulian joejulian deleted the dkoshkin-upgrade-delete branch October 5, 2020 23:01
@alejandroEsc alejandroEsc changed the title cert-manager/fluentbut: upgrade-strategy delete cert-manager/fluentbit: upgrade-strategy delete Oct 6, 2020
@joejulian joejulian added this to the release/2.6 milestone Oct 6, 2020
joejulian pushed a commit that referenced this pull request Oct 6, 2020
* fluentbit: add upgrade strategy delete after selector change

Signed-off-by: Dimitri Koshkin <[email protected]>

* cert-manager: add upgrade strategy delete after selector change

Signed-off-by: Dimitri Koshkin <[email protected]>
joejulian added a commit that referenced this pull request Oct 6, 2020
* fluentbit: add upgrade strategy delete after selector change

Signed-off-by: Dimitri Koshkin <[email protected]>

* cert-manager: add upgrade strategy delete after selector change

Signed-off-by: Dimitri Koshkin <[email protected]>

Co-authored-by: Dimitri Koshkin <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants