This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
cert-manager/fluentbit: upgrade-strategy delete #574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracedo
reviewed
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you bump the catalog.kubeaddons.mesosphere.io/addon-revision
's, otherwise lgtm!
Signed-off-by: Dimitri Koshkin <[email protected]>
Signed-off-by: Dimitri Koshkin <[email protected]>
dkoshkin
force-pushed
the
dkoshkin-upgrade-delete
branch
from
October 5, 2020 20:37
bf04a12
to
40de466
Compare
gracedo
approved these changes
Oct 5, 2020
Tested locally by upgrading from Konvoy
|
joejulian
approved these changes
Oct 5, 2020
alejandroEsc
changed the title
cert-manager/fluentbut: upgrade-strategy delete
cert-manager/fluentbit: upgrade-strategy delete
Oct 6, 2020
joejulian
pushed a commit
that referenced
this pull request
Oct 6, 2020
* fluentbit: add upgrade strategy delete after selector change Signed-off-by: Dimitri Koshkin <[email protected]> * cert-manager: add upgrade strategy delete after selector change Signed-off-by: Dimitri Koshkin <[email protected]>
joejulian
added a commit
that referenced
this pull request
Oct 6, 2020
* fluentbit: add upgrade strategy delete after selector change Signed-off-by: Dimitri Koshkin <[email protected]> * cert-manager: add upgrade strategy delete after selector change Signed-off-by: Dimitri Koshkin <[email protected]> Co-authored-by: Dimitri Koshkin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
What this PR does/ why we need it:
The Deployment selectors changed for
fluentbit
andcert-manager
, need to use thedelete
upgrade-strategy
.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist