Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

[release/2.5] backport: cert-manager/fluentbit: upgrade-strategy delete (#574) #576

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[release/2.5] backport: cert-manager/fluentbit: upgrade-strategy delete (#574) #576

merged 1 commit into from
Oct 6, 2020

Conversation

joejulian
Copy link
Contributor

@joejulian joejulian commented Oct 6, 2020 •
edited
Loading

What type of PR is this?

Bug

What this PR does/ why we need it:

The Deployment selectors changed for fluentbit and cert-manager, need to use the delete upgrade-strategy.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- cert-manager: The Deployment selectors were changed, use `delete` `upgrade-strategy`.
- fluentbit: The Deployment selectors were changed, use `delete` `upgrade-strategy`.

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@dkoshkin @joejulian
cert-manager/fluentbut: upgrade-strategy delete (#574)
abb7500 
* fluentbit: add upgrade strategy delete after selector change

Signed-off-by: Dimitri Koshkin <[email protected]>

* cert-manager: add upgrade strategy delete after selector change

Signed-off-by: Dimitri Koshkin <[email protected]>
@joejulian joejulian requested review from a team as code owners October 6, 2020 18:40
@joejulian joejulian added this to the release/2.5 milestone Oct 6, 2020
@joejulian joejulian added the ready label Oct 6, 2020
@joejulian joejulian self-assigned this Oct 6, 2020
@joejulian joejulian changed the base branch from master to release/2.5 October 6, 2020 18:41
@joejulian joejulian merged commit b14dd86 into release/2.5 Oct 6, 2020
@joejulian joejulian deleted the release/2.5-cherry-pick_574 branch October 6, 2020 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@joejulian joejulian

Labels
ready
Projects
None yet
Milestone
release/2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@joejulian @dkoshkin