chore: bump dynamic-credential-provider to v0.5.3 #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
reviewed
May 20, 2024
| @@ -59,7 +59,7 @@ aws_images: [] | |||
|
|
|||
| extra_images: [] | |||
|
|
|||
| containerd_supplementary_images: ["ghcr.io/mesosphere/toml-merge:v0.2.0", "ghcr.io/mesosphere/dynamic-credential-provider:v0.2.0", "ghcr.io/mesosphere/dynamic-credential-provider:v0.5.0"] | |||
| containerd_supplementary_images: ["ghcr.io/mesosphere/toml-merge:v0.2.0", "ghcr.io/mesosphere/dynamic-credential-provider:v0.2.0", "ghcr.io/mesosphere/dynamic-credential-provider:v0.5.3"] | |||
There was a problem hiding this comment.
Why do we need both ghcr.io/mesosphere/dynamic-credential-provider:v0.2.0 and v0.5.3?
There was a problem hiding this comment.
I honestly does not have context about this. @dkoshkin any idea?
There was a problem hiding this comment.
This was the PR that added v0.5.0 #1019
Konvoy is still using v0.2.0 and the old API https://github.com/mesosphere/konvoy2/blob/051fdf94628a09028d0c4befe8d27b04876d37f7/pkg/capi/generator/templates/dynamic-credential-provider-config.yaml.gotmpl#L12
I think we should keep v0.2.0 like you did here and cut another ticket to do the API migration in Konvoy.
There was a problem hiding this comment.
Thank you for the context
dkoshkin
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
bumps dynamic credentials provider to v0.5.3