Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deploy ceph BucketClass by default #3034

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Conversation

takirala
Copy link
Contributor

What problem does this PR solve?:

  • bumps the cosi-bucket-kit chart version and updates the values structure.
  • deploys BucketClass and BucketAccessClass by default whenever ceph is deployed.

This change will make it easy for UI to list all the available BucketClasses.

Depends on mesosphere/charts#1540

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. services/rook-ceph-cluster services/kubecost labels Jan 17, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 17, 2025
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/tga/refactor-ceph-cosi

@coveralls
Copy link

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12940172145

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 12935824509: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2025
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala takirala self-assigned this Jan 23, 2025
@takirala takirala marked this pull request as ready for review January 23, 2025 18:45
@takirala takirala requested a review from a team January 23, 2025 22:26
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala takirala merged commit 56b994a into main Jan 24, 2025
26 checks passed
@takirala takirala deleted the tga/refactor-ceph-cosi branch January 24, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/kubecost services/rook-ceph-cluster size/M Denotes a PR that changes 30-99 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants