Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update kubectl to 1.31.4 #3023

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

saikumar98419
Copy link
Contributor

What problem does this PR solve?:
update kubectl to latest 1.31.4

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-105180

@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2025
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/bump-kubecl-version

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. services/kommander services/kubefed services/nkp-insights labels Jan 16, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12823964761

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 12805589008: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

Comment on lines -539 to 543
- container_image: docker.io/bitnami/kubectl:1.29.6
- container_image: docker.io/bitnami/kubectl:1.31.4
sources:
- url: https://github.com/kubernetes/kubectl
ref: v0${image_tag#1}
license_path: LICENSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these lines as we're going to have only single kubectl image ref.

@@ -1126,7 +1126,7 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
image: bitnami/kubectl:1.29.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwyl02 we have a different way of replacing the image?

Comment on lines +71 to +72
- name: generate-admin-password
image: "${kubetoolsImageRepository:=bitnami/kubectl}:${kubetoolsImageTag:=1.31.4}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: generate-admin-password
image: "${kubetoolsImageRepository:=bitnami/kubectl}:${kubetoolsImageTag:=1.31.4}"

Copying issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants