-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update kubectl to 1.31.4 #3023
base: main
Are you sure you want to change the base?
Conversation
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/bump-kubecl-version |
Pull Request Test Coverage Report for Build 12823964761Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
- container_image: docker.io/bitnami/kubectl:1.29.6 | ||
- container_image: docker.io/bitnami/kubectl:1.31.4 | ||
sources: | ||
- url: https://github.com/kubernetes/kubectl | ||
ref: v0${image_tag#1} | ||
license_path: LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these lines as we're going to have only single kubectl image ref.
@@ -1126,7 +1126,7 @@ spec: | |||
valueFrom: | |||
fieldRef: | |||
fieldPath: metadata.namespace | |||
image: bitnami/kubectl:1.29.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwyl02 we have a different way of replacing the image?
- name: generate-admin-password | ||
image: "${kubetoolsImageRepository:=bitnami/kubectl}:${kubetoolsImageTag:=1.31.4}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: generate-admin-password | |
image: "${kubetoolsImageRepository:=bitnami/kubectl}:${kubetoolsImageTag:=1.31.4}" |
Copying issue?
What problem does this PR solve?:
update kubectl to latest 1.31.4
Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-105180