Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: shim demo fixups #24

Merged
merged 3 commits into from
Nov 22, 2022
Merged

refactor: shim demo fixups #24

merged 3 commits into from
Nov 22, 2022

Conversation

dkoshkin
Copy link
Contributor

The first commit fixes the script on my Mac, not sure if this will break on Linux.
The second commit changes the demo script so it uses the static-credential-provider binary.

➜  hack git:(jimmi/implement-shim) ✗ ./demo.sh
...
pod/nginx-latest created
pod/nginx-mirror created
pod/nginx-stable created
pod/nginx-latest condition met
pod/nginx-stable condition met
pod/nginx-mirror condition met
➜  hack git:(jimmi/implement-shim) ✗ k get pods -A
NAMESPACE            NAME                                                                   READY   STATUS    RESTARTS   AGE
default              nginx-latest                                                           1/1     Running   0          15s
default              nginx-mirror                                                           1/1     Running   0          15s
default              nginx-stable                                                           1/1     Running   0          15s
kube-system          coredns-565d847f94-4z6vh                                               1/1     Running   0          22s
kube-system          coredns-565d847f94-rg4dm                                               1/1     Running   0          22s
kube-system          etcd-image-credential-provider-test-control-plane                      1/1     Running   0          37s
kube-system          kindnet-fnrgj                                                          1/1     Running   0          22s
kube-system          kube-apiserver-image-credential-provider-test-control-plane            1/1     Running   0          36s
kube-system          kube-controller-manager-image-credential-provider-test-control-plane   1/1     Running   0          36s
kube-system          kube-proxy-cxw7h                                                       1/1     Running   0          22s
kube-system          kube-scheduler-image-credential-provider-test-control-plane            1/1     Running   0          37s
local-path-storage   local-path-provisioner-684f458cdd-mvlc9                                1/1     Running   0          22s

@dkoshkin dkoshkin requested a review from jimmidyson November 22, 2022 00:58
jimmidyson
jimmidyson reviewed Nov 22, 2022
View reviewed changes
hack/demo.sh Outdated Show resolved Hide resolved
Base automatically changed from jimmi/implement-shim to main November 22, 2022 10:24
dkoshkin and others added 3 commits November 22, 2022 10:48
@dkoshkin @jimmidyson
refactor: fix demo script to won on a Mac pushing images
f6162f8 
latest: Pulling from library/nginx
Digest: sha256:e209ac2f37c70c1e0e9873a5f7231e91dcd83fdf1178d8ed36c2ec09974210ba
Status: Image is up to date for nginx:latest
docker.io/library/nginx:latest
Error response from daemon: Get "http://localhost:5000/v2/": net/http: request canceled (Client.Timeout exceeded while awaiting headers)
@dkoshkin @jimmidyson
refactor: use static-credential-provider binaries in the demo script
802bfcb
@jimmidyson
fix: Rever demo to use localhost instead of 0.0.0.0
9f712e1
@jimmidyson jimmidyson force-pushed the dkoshkin/implement-shim-demo-fixups branch from 1cb6913 to 9f712e1 Compare November 22, 2022 10:50
@jimmidyson jimmidyson merged commit 25c353d into main Nov 22, 2022
@jimmidyson jimmidyson deleted the dkoshkin/implement-shim-demo-fixups branch November 22, 2022 10:52
@github-actions github-actions bot mentioned this pull request Nov 22, 2022
Closed
@github-actions github-actions bot mentioned this pull request Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmidyson jimmidyson jimmidyson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkoshkin @jimmidyson